Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Risk Of Bias review tasks dashboard #964

Merged
merged 5 commits into from Jan 4, 2024
Merged

Risk Of Bias review tasks dashboard #964

merged 5 commits into from Jan 4, 2024

Conversation

shapiromatron
Copy link
Owner

A prior PR, #808, removed what we thought was an unused list of study evaluations a user is currently assigned but have not yet completed. We heard from users that this feature was used, so we've added it back in this PR.

  • Add a list of incomplete study evaluations at the assessment mgmt level, as well as the overall user level
    • /mgmt/assessment/:id/tasks/
    • /mgmt/tasks/

image


In addition, updated the navbar to only show the "about" and "resources" pages if the user is not logged in and the new documentation tab is not enabled. I found that even with a "wide" laptop monitor of 1440px, with the EPA flavor of the styles, it wouldn't fit on the a single line with the HAWC title as well.

@caseyhans
Copy link
Collaborator

This list includes tasks for published assessments, which are tasks that users can't work on/submit. I'm not sure if this is as intended but it's worth noting. Overall, it looks good to me, but I did make some minor style tweaks:

  • Added a .dark-link class so all links in an list-item-action list are the same color, regardless of whether they've been visited or not. Abstracted to a separate class since it might be useful in other locations
  • Removed bottom margins for the new subheaders
  • Fixed the 'logout' button active state color; it's bothered me for a while, and we're touching nearby code anyway

Copy link
Collaborator

@caseyhans caseyhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see above comment.

@shapiromatron
Copy link
Owner Author

@caseyhans we could filter for study__assessment__editable=True to only show those studies which are on editable assessments. I think our test fixture may just be a bad example; seeing all the stuff that's on your queue might be ok with real world projects. Are you ok keeping it as is, or should we add this additional filter?

@caseyhans
Copy link
Collaborator

@caseyhans we could filter for study__assessment__editable=True to only show those studies which are on editable assessments. I think our test fixture may just be a bad example; seeing all the stuff that's on your queue might be ok with real world projects. Are you ok keeping it as is, or should we add this additional filter?

I'm good with keeping it as is!

@shapiromatron shapiromatron merged commit 371c1fa into main Jan 4, 2024
3 checks passed
@shapiromatron shapiromatron deleted the rob-review-tasks branch January 4, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants