Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add duplicate reference check #965

Merged
merged 6 commits into from Jan 5, 2024
Merged

add duplicate reference check #965

merged 6 commits into from Jan 5, 2024

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Dec 20, 2023

Adds a validation check on HERO imports to ensure there are not duplicate ID types (HERO, PubMed, WoS, or DOI). Previously, the import failed but did not notify the user of which IDs were duplicates.

@caseyhans caseyhans marked this pull request as ready for review January 3, 2024 16:37
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one recommended change to remove an unused line.

hawc/apps/lit/managers.py Outdated Show resolved Hide resolved
@caseyhans caseyhans merged commit 08d22f4 into main Jan 5, 2024
3 checks passed
@caseyhans caseyhans deleted the duplicate-refs-validation branch January 5, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants