Improve performance of exploratory heatmap datatable #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Works great, nice job! I made some minor edits (8da7675) to the data table constructor just to make it more clear what the possible options states are, but no functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the React wrapper for datatables is used for a large dataset, it would take a long time to load. This was due to the fact that the large dataset was rendered as a regular table first before being passed to datatables.
This fix uses the
dataandcolumnsoption for datatables to render the table using data instead of the fully rendered DOM table; the old way is still supported for smaller tables, such as the generic summary tables. A loading component was also added to convey to the user when datatables is generating a table.