Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to JSON require based system #6

Closed
wants to merge 1 commit into from

Conversation

thammi
Copy link

@thammi thammi commented May 14, 2020

I wanted to use this package in my own project and implemented some improvements. I replaced the parsing of the files at runtime with require() on JSON files. This was needed to integrate the package in a browser based project and should perform better.

I also simplified the generation process. If you would like to merge the JSON require() part but not the adjustments to the algorithm I could split the commit up.

My version is currently published as readable-url-names.

@sharadbhat
Copy link
Owner

Hey man, that would be great! Although, could you split it up and keep only the imports and package.json updates?

Also, how is your generation process different from what I've implemented?

@thammi
Copy link
Author

thammi commented Jun 7, 2020

I didn't really like the concept of "filler words" ("a", "the") and that they counted towards the word count. I removed them and simplified the generation a bit.

I will split it up, noticed that I should have done that the moment I pushed but was too lazy to fix immediately ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants