-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Integration #5
Comments
Hey! Thanks for reaching out. Yes, this is something I do have on my roadmap 😃. That sounds like a fine plan. To confirm we're on the same page, what image will you be basing on for the frontend? Is it nginx? Asking because I'm only familiar with nginx so, if it's something else, I'll have some reading up to do. Go ahead. I'll assign this to you. Let me know if you need any pointers in navigating the codebase. PS: I'm told by my peers that I'm quite a bit picky when doing code-reviews. Just a heads-up. 😬 |
For the development image I'd recommend we base off an official NodeJS image, as it looks like you use parcel to hot reload the files and run it - Line 53 in c74d34a
For production, I suppose it depends on you're hosting the app at the moment, is it static files hosted on Netlify? If so, nginx could work, or maybe Docker ought to be just for development purposes? |
Ah interesting. I didn't realize we'd have a separate Dockerfile for development. Yeah that would require NodeJS to run Parcel. For production, you are right. It's just a bunch of static files, built with Parcel, hosted on Netlify. Docker images for prod is actually what intended when I added that line to the Roadmap. So I'd say the development Dockerfiles are optional, but we'd want the production ones. |
Hey @sharat87, wanted to let you know I haven't forgotten about this 😄 Taken a look this morning, I've got the frontend working but the backend isn't quite working yet. I've got some ideas on how to get it working. Can I just check these assumptions are right before I go down any rabbit holes:
Also what's a good way of checking the API is working? Do you have some sample requests I could use? I can see on your deployment there's a auth check (GET /api/auth/profile), maybe that would be a good one? |
Hey @MattTennison, thanks for dropping an update, I was wondering about this myself 😄. Regarding your assumptions,
For health check, yeah, let's use the |
Closing this since a |
Hi,
I like the idea of this project, and I notice in your roadmap you have Docker as one of the upcoming features.
I've done this sort of stuff a few times so would love to take a crack at it, if that's okay? I'd submit a PR with:
Maybe with the docker-compose running the apps in dev/hot reload mode, but have the Dockerfiles build "production" images in a separate, final stage.
How does that sound?
The text was updated successfully, but these errors were encountered: