Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Competing to activity types #21

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

kaine119
Copy link
Contributor

@kaine119 kaine119 commented Jan 9, 2021

Summary

Add support for Competing activity type to Activity and Bot. Fixes #14.


Added

  • Activity::COMPETING, ActivitySet#competing
  • Bot#competing= to set the competing status
  • Updated comments to add Competing to the list of activity types

@kaine119
Copy link
Contributor Author

kaine119 commented Jan 9, 2021

@swarley mentioned adding an identification method Activity#competing?, but those are currently used only for activity flags, not for activity types. Should we add identifications for all of those too, or leave it as is?

@swarley
Copy link
Member

swarley commented Jan 9, 2021

You were correct to leave it out 😅. I had assumed, for some reason, we had an abstracted way to identify the type.

We can put a pin in that for now, since adding something like that should be its own PR.

@swarley swarley merged commit d572a3e into shardlab:main Jan 16, 2021
@swarley
Copy link
Member

swarley commented Jan 16, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for COMPETING activity type
2 participants