Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about using deprecated features #228

Merged
merged 3 commits into from
Aug 1, 2018

Conversation

gkubisa
Copy link
Contributor

@gkubisa gkubisa commented Jul 20, 2018

I've also removed doc from README.md because the other deprecated action, "after submit" was not there either.

@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage increased (+0.02%) to 95.199% when pulling 39a95c8 on Teamwork:warn-about-deprecated-features into 721a0ab on share:master.

@nateps
Copy link
Contributor

nateps commented Aug 1, 2018

Thanks, @gkubisa! Great idea to notify users about feature deprecation. I think we should start following this example with other breaking changes in ShareDB. 👍

@nateps nateps merged commit ac9fcd4 into share:master Aug 1, 2018
@stanographer
Copy link

I'm following this thread but I'm still not exactly sure how to get rid of these warnings. As far as I can tell these warnings are originating from the actual source code itself, and not the way I'm implementing ShareDB? Could someone please enlighten me? Thanks!!

@alecgibson
Copy link
Collaborator

@stanographer as the warning says, pass the disableSpaceDelimitedActions: true when constructing ShareDB to disable both the warning, and the middleware that uses spaced names.

@curran
Copy link
Contributor

curran commented Dec 19, 2018

@stanographer It was not obvious to me either, exatly where/how these options should be pased in.

It turns out they need to be passed as properties of the object passed as the first argument to the ShareDB constructor, like this:

  const backend = new ShareDB({
    // The following options serve only to squelch errors.
    // It should be possible to remove these when ShareDB 1.0 is released.
    disableDocAction: true,
    disableSpaceDelimitedActions: true
  });
  const connection = backend.connect();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants