revert to using a simple shallowCopy for ops #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng is a breakign change if you've added new fields in middleware
ericyhwang
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ops were copied by iterating over them in pubsub. This was changed in #316 to copy the specific properties expected on an op. Copying the specific properties is faster than iterating and allows use of specifically typed objects.
However, this ended up being a breaking change, because middleware could be adding additional fields to the top level of the op, which do end up getting committed and fetched. Perhaps a way to add additional op fields explicitly should be implemented, but for now, let's just revert, since this was not intended to be breaking.