Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter example with ottype json1 #382

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Counter example with ottype json1 #382

merged 3 commits into from
Aug 5, 2020

Conversation

eMarek
Copy link
Contributor

@eMarek eMarek commented Jul 20, 2020

No description provided.

@eMarek eMarek mentioned this pull request Jul 20, 2020
Closed
curran
curran approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Thank you for putting this together.

@curran
Copy link
Contributor

curran commented Jul 22, 2020

@eMarek Please make CI pass. Thanks! https://travis-ci.org/github/share/sharedb/jobs/710165756#L222

@ericyhwang
Copy link
Contributor

Looks like it's just linting errors:
https://travis-ci.org/github/share/sharedb/jobs/710165756

Should be auto-fixable with:

eslint --ignore-path .gitignore '**/*.js' --fix

@alecgibson
Copy link
Collaborator

Pro-tip: npm run lint:fix

@marcusnewton marcusnewton mentioned this pull request Jul 23, 2020
Closed
eMarek and others added 2 commits July 26, 2020 23:52
@eMarek @curran
Using type uri instead of hardcoded string
58281a7 
Co-authored-by: Curran Kelleher <curran.kelleher@gmail.com>
@eMarek
Lint fixes
5b40c32
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0008%) to 97.357% when pulling 5b40c32 on eMarek:master into a81e2c9 on share:master.

curran
curran approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericyhwang ericyhwang merged commit 89931c0 into share:master Aug 5, 2020
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyhwang ericyhwang ericyhwang left review comments

@curran curran curran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eMarek @curran @ericyhwang @alecgibson @coveralls