Catch errors thrown in ot.applyOps
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ot.applyOps` utility function directly calls type methods, such as `type.apply`. These type methods can potentially `throw`. This results in an uncaught error, which we should avoid. This change wraps the `ot.applyOps` functionality in a `try`/`catch` block and returns the error, so that it can be handled appropriately. We add a new `ERR_OT_OP_NOT_APPLIED` error code for this case.
ericyhwang
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ot.applyOpsutility function directly calls type methods, such astype.apply. These type methods can potentiallythrow. This resultsin an uncaught error, which we should avoid.
This change wraps the
ot.applyOpsfunctionality in atry/catchblock and returns the error, so that it can be handled appropriately.
We add a new
ERR_OT_OP_NOT_APPLIEDerror code for this case.