Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 Pin json0 dev dependency #567

Merged
merged 1 commit into from
Jul 12, 2022
Merged

📌 Pin json0 dev dependency #567

merged 1 commit into from
Jul 12, 2022

Conversation

alecgibson
Copy link
Collaborator

It's best practice to specify a version when depending directly on a
repo.

It's best practice to specify a version when depending directly on a
repo.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.41% when pulling bec7e6d on pin-json0 into 8ed35d5 on master.

@ericyhwang
Copy link
Contributor

Note - This is on top of a change that switches the dependency from ottypes/json0 to https://github.com/ottypes/json0:
400ec52
b1c10d6

That fixed an issue where an install on NPM 6 hanged. GitHub turned off support for unencrypted Git protocol requests, and it seems that NPM 6 defaults to those.
https://twitter.com/ruyadorno/status/1526388587918499842?s=20&t=20Pt1gZThwZ5AoKgaYHf5w
https://github.blog/2021-09-01-improving-git-protocol-security-github/

@alecgibson alecgibson merged commit 106e959 into master Jul 12, 2022
@alecgibson alecgibson deleted the pin-json0 branch July 12, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants