Refactor action code strings into an enum-like object #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action codes used in
request.a
are currently string literals in the source code, e.g.qf
(query fetch) ors
(subscribe). That makes the code harder to navigate and learn.This PR refactors them into an enum-like object, such that they can be used like
Action.QueryFetch
.As a bonus, it'll help if/when we find the time to switch to TypeScript, too!
Things to discuss and look at:
shared/
directory for it, since it's code shared between client and server.sharedb/lib/client/connection.js
Lines 381 to 383 in e828fbb