⚡️ Deduplicate fetch() network requests
#610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solution looks good, but will it cause a situation where a request will never be sent after a fetch fails. So I feel that some more cases can be added, maybe it would be better to use throttle? |
|
@Qquanwei why wouldn't subsequent fetches succeed? We clear inflight even if there's an error, so a second fetch will send another request. Do you have a failing test case? |
|
Thank you for your reply. I re-checked the code and found that inflightFetch will be cleared when the fetch error occurs. If this logic can work normally (for example, it can work normally without receiving any fetch reply), then this pr Should solve my problem. |
At the moment, if a client calls `doc.fetch()` with a fetch request already in progress, the client will send a second request, which probably isn't needed (or wanted). This change prevents duplicate requests from being sent when there's already an inflight fetch request, and adds an internal `force` option, which can be used to force a duplicate request to be sent. This is currently used internally for `_hardRollback()`, which forcibly unsets the `doc.version`, and therefore requires a separate `fetch()` call, since fetch requests are [handled differently][1] depending on the presence of `version`. [1]: https://github.com/share/sharedb/blob/21750e320f6865ee14620d6bf9610cb7ebc5f18e/lib/agent.js#L607
alecgibson
force-pushed
the
merge-inflight-fetch
branch
from
8a1dbe5
to
05a74aa
Compare
ericyhwang
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if a client calls
doc.fetch()with a fetch request already in progress, the client will send a second request, which probably isn't needed (or wanted).This change prevents duplicate requests from being sent when there's already an inflight fetch request, and adds an internal
forceoption, which can be used to force a duplicate request to be sent. This is currently used internally for_hardRollback(), which forcibly unsets thedoc.version, and therefore requires a separatefetch()call, since fetch requests are handled differently depending on the presence ofversion.