馃悰 Prevent caching presence broadcasts rejected by middleware #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyhwang
approved these changes
Dec 5, 2023
The `Agent` stores the most recent presence broadcast sent by a client. However, it eagerly stores this before running the `receivePresence` middleware, which may actually decide that the presence broadcast is invalid (eg malformed, unauthorized, etc.). This means that the latest cached presence state may not be "legal". This change moves the caching inside the `trigger()` call, so we only store presence values that have "passed" the middleware.
alecgibson
force-pushed
the
receive-presence-middleware
branch
from
df34bad
to
cfcf5c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Agentstores the most recent presence broadcast sent by a client. However, it eagerly stores this before running thereceivePresencemiddleware, which may actually decide that the presence broadcast is invalid (eg malformed, unauthorized, etc.).This means that the latest cached presence state may not be "legal".
This change moves the caching inside the
trigger()call, so we only store presence values that have "passed" the middleware.