Fix flaky pollDebounce tests #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just checking whether there are 2 batches of documents passed through the 'insert' event, make sure we get exactly 1 document in the first batch and the rest of them (9) in the second batch.
The pollDebounce tests insert 10 documents and make sure that debouncing leads to two separate chunks of documents being passed through the 'insert' callback on the query. The problem was that we weren't waiting for the document creation to be submitted before sending the next document. Even though the original test behavior was a more accurate representation of what a real client would do, it lead to unpredictable results. The timing of when the op was submitted could have lead to all of the documents being added in one single chunk, rather than two.
|
Yep, looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pollDebounce tests insert 10 documents and make sure
that debouncing leads to two separate chunks of documents
being passed through the 'insert' callback on the query.
The problem was that we weren't waiting for the document
creation to be submitted before sending the next document.
Even though the original test behavior was a more accurate
representation of what a real client would do, it lead to
unpredictable results. The timing of when the op was submitted
could have lead to all of the documents being added in one single
chunk, rather than two.
While at it, made the test more strict -- it now checks the sizes
of the two chunks passed through the 'insert' callback, rather
than just the number of chunks.