-
Notifications
You must be signed in to change notification settings - Fork 233
TSLint errors question #98
Comments
Hi @pr0peller. If you paste the output here I can check it tomorrow |
Hi,
(node:14208) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version. D:__Source\Repos\PnP-JS-Core (dev) (sp-pnp-js@0.0.10)` Thank you @pbjorklund |
@pbjorklund @pr0peller I got these same errors out of nowhere the other day. I had to move all of the failing items above the constructor to make the errors go away. I assumed the tslint rules changed and that a PR was probably pending already to fix it. |
Same here. Lint was fine yesterday. Thanks for the info @mike-morrison |
Is this against the master or dev branch? |
@pbjorklund It is against dev branch |
@pbjorklund Same issue against master branch - just checked! |
I just pulled dev and ran gulp lint and could not reproduce this. tslint rules haven't changed so far as I am aware. |
I could reproduce it couple of days back from dev branch, while working on my PR. I didn't commit my tslint.json then, which I used to check successful build. Wanted to raise the issue myself too |
I had the isues on Saturday and changed my talking to fix it |
I noticed it for the first time on a Mac, but I am pretty sure I got it on Windows too. |
I just noticed you are doing "npm test" instead of "gulp test". I re-pulled latest from dev and tried that and it worked as expected. So far as I know nothing had changed on my machine, and I am pulling from the dev branch in git with no local changes. tslint.json hasn't been updated in some time. Unsure, if someone who can reproduce this can investigate that would be appreciated but everything appears fine. I have version 3.3.12 of tslint, but haven't done anything special to it (at least that I am aware of). |
It has to do with an issue in TSLint seems, not with what we were doing. I'm using TSLint 3.8.0 and have the issue. |
It has to do with the fact that we use caret ranges for tslint and gulp-tslint. @biste5 is most likely correct that it will be solved upstream soon enough. We could lock down versions to specific versions in package.json. For now you can resolve with |
I'll check my version of TSLint when I get home, but I think I'm running 3.8.0 also. Not 100% sure though ... |
I'm using TSLint 3.9.0 downgraded to 3.6.0 as @pbjorklund advice and now it is working. |
So before I close this want to confirm:
|
Correct, With TSLint 3.6.0 works. The Issue is in the newer version of TSLint tool. |
Thanks, I'll close this. Appreciate everyone who had a look. |
Hi,
I'm trying to build the solution and I keep getting errors during linting process.
Declaration of private instance member variable not allowed to appear after declaration of public instance member function
.few files only, but enough to ruin the build. Everything builds and test pass without linting.
Does anybody experience the same issue or it's just me?
Thanks in advance
The text was updated successfully, but these errors were encountered: