Return the Vimaly ticket-id after successfully updating a ticket

sharesight · Aug 22, 2018 · 2a552be · 2a552be
1 parent b96a25d
commit 2a552be
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/lib/vimaly/client.rb b/lib/vimaly/client.rb
@@ -45,7 +45,7 @@ def update_ticket(id, other_fields)
       response = put("/tickets/#{id}", ticket.to_json(custom_field_name_map, true))
       case response.status
       when 200..299
-        true
+        id
       else
         log_warn "status: #{response.status}"
         log_warn "        #{response.inspect}"

diff --git a/test/client_test.rb b/test/client_test.rb
@@ -98,22 +98,24 @@ class ClientTest < Minitest::Test
     should "succeed for standard params" do
       stub_update_ticket
 
-      @client.update_ticket(
-          123,
-          title: 'updated title',
-          description: 'updated description'
+      id = @client.update_ticket(
+        123,
+        title: 'updated title',
+        description: 'updated description'
       )
+      assert_equal 123, id
     end
 
     should "succeed for custom params" do
       stub_update_ticket_custom
 
-      @client.update_ticket(
-          123,
-          title: 'updated title',
-          description: 'updated description',
-          'Last seen': Date.new(2016,1,20)
+      id = @client.update_ticket(
+        123,
+        title: 'updated title',
+        description: 'updated description',
+        'Last seen': Date.new(2016,1,20)
       )
+      assert_equal 123, id
     end
   end # updating tickets