Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Generic fixes #3

Merged
merged 2 commits into from
Apr 9, 2014
Merged

Generic fixes #3

merged 2 commits into from
Apr 9, 2014

Conversation

jaywink
Copy link
Contributor

@jaywink jaywink commented Apr 9, 2014

  • Remove dead pods. Now 10 pods listed in the order of most monthly users from pods.jasonrobinson.me.
  • Fix branding - 'diaspora*' is the correct styling.
  • Add favicon here that used to be pulled from joindiaspora.com
  • Fix sharing code examples according to comments from Cyprien Pouzenc. Basically moving the javascript from href to onclick avoids a blank page with [object Window] in some cases.

Mind these in one pull? ;) I assume index.html needs to be minified for things to work - any tips on what you've used or you want to do it - assuming these changes are ok?

Remove dead pods. Now 10 pods listed in the order of most monthly users from pods.jasonrobinson.me.
Fix branding - 'diaspora*' is the correct styling.
Add favicon here that used to be pulled from joindiaspora.com
Basically moving the javascript from href to onclick avoids a blank page with [object Window] in some cases
@fdavidcl
Copy link
Contributor

fdavidcl commented Apr 9, 2014

Whoa, thank you so much! I know I should be the one doing this, but I'm not so active on Diaspora lately...

Yup, I like the index.html to be minified so that the file is as lightweight as possible (the sharing page is supposed to load fast so the user doesn't have to wait). I don't remember what tool I used last time, but don't worry, I'll do that. I'll also fix a little thing about the onclick, we shouldn't put javascript: there.

sharetodiaspora is now an organization, so if you want to be a member, I'll add you (it'll make things easier for you if you want to continue contributing, but you don't have to, at all, this is something I should be maintaining myself).

@fdavidcl fdavidcl merged commit 495beeb into sharetodiaspora:master Apr 9, 2014
@jaywink
Copy link
Contributor Author

jaywink commented Apr 9, 2014

Awesome! If you want to add me - that would be an honour :) I'd totally love to help keep this up to date with whatever happens in the future, being very active in the d* organization at the moment.

One option would of course be to transfer this to the diaspora organization - kind of merge the two? If you don't want to keep maintaining this, I'd be happy to propose such a thing.

Thanks for accepting the patch and making the tweaks :)

@fdavidcl
Copy link
Contributor

fdavidcl commented Apr 9, 2014

Of course, opening this to the diaspora community would be great! ^^

But before that, I just thought I could include some sort of localization (maybe with Mozilla's l20n), because I saw a fork in German, so why not translate it to other languages? I think I can get that done between tomorrow and the weekend, and after that I'd love to transfer it to the diaspora organization - if you guys accept it, of course.

Thank you again for contributing ^^

@fdavidcl
Copy link
Contributor

Well, I think I'm done with the localization, I don't know if there's anything more I can do, for now.

So, when you want (there's no hurry at all), if you'd still like to transfer this to the diaspora* organization, I'd be honoured. Or if you prefer it to continue as a separate project, I'd be happy as well. I'll still be here helping on what I can, of course :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants