Split commands namespace #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This commits splits the commands namespace to the following namespaces:
- command-defs: Namespace that contains the CLI commands definitions and pointers to handler functions. This namespace needs to require all command handler namespalces
- command-util: Namespace for util function for accessing and traversing the command definitions data structure
- command-exec: Namespace for executing a command handler after the CLI arguments have been parsed
- command-spec: Namespace for command specs.
The split was needed to resolve cyclic dependencies that happen easily because a help command handler is referenced in the command definitions structure, but the help handler itself needs to be aware of the command definitions structure in order to render the help.
The dependency graph is now following:
- core depends on:
- args-parse depends on:
- command-spec
- command-defs depedns on:
- ...all command handlers
- command-exec
kpuputti
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #19
This commits splits the commands namespace to the following namespaces:
The split was needed to resolve cyclic dependencies that happen easily because a help command handler is referenced in the command definitions structure, but the help handler itself needs to be aware of the command definitions structure in order to render the help.
The dependency graph is now following: