Assets #154
Merged
Assets #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rap1ds
force-pushed
the
assets
branch
2 times, most recently
from
231add0
to
be92254
Compare
OtterleyW
approved these changes
Mar 14, 2022
src/sdk.js
Outdated
| @@ -402,7 +456,7 @@ const createMarketplaceApiEndpointInterceptors = httpOpts => | |||
| // | |||
| marketplaceApiEndpoints.reduce((acc, { path, method, multipart }) => { | |||
| const fnPath = urlPathToFnPath(path); | |||
| const url = `api/${path}`; | |||
| const urlTemplate = _.template(`api/${path}`); | |||
There was a problem hiding this comment.
I found it difficult at first to understand what this change from url to urlTemplate means to why it was made. I think I got it but maybe it would be nice to have a code comment somewhere to explain what's happening.
rap1ds
force-pushed
the
refactor-before-assets
branch
from
f6315c3
to
1077819
Compare
rap1ds
force-pushed
the
assets
branch
3 times, most recently
from
d0ae704
to
ce7cb9f
Compare
Lodash template seems to have some CSP issues (lodash/lodash#832). The downside of using JS templates (+ a wrapping function) is that the endpoints.js isn't pure data anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Assets. It's based on #155
In this PR:
Interface looks like this: