Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-asset fetching #170

Merged
merged 6 commits into from May 9, 2023
Merged

Add support for multi-asset fetching #170

merged 6 commits into from May 9, 2023

Conversation

bladealslayer
Copy link
Member

@bladealslayer bladealslayer commented Jan 11, 2023

Don't merge until release and keep the branch on top of master.

TODO:

  • remove build before merging for release

Two new SDK fns: assetsByAlias() and assetsByVersion().

Copy link
Member

@rap1ds rap1ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, commented something about the longest path algo

src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
Copy link
Contributor

@lyyder lyyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Check also the error message on line 351, in the asset by version request, that was not updated in this PR, there seems to be 'alias' instead of 'version':

      if (!version) {
        throw new Error('Missing mandatory parameter `alias`');
      }

src/sdk.js Outdated Show resolved Hide resolved
src/sdk.js Outdated Show resolved Hide resolved
@walterrw walterrw force-pushed the multi-asset-api branch 4 times, most recently from a560531 to 425f2ef Compare January 17, 2023 10:16
return `${path}/`;
}

const { length: l, 0: first, [l - 1]: last } = sortedPathParts;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whou I did not know you can do destructions like this. TIL!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just learned it also while I was doing this 😀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that typo / autocorrect :)

Two new SDK fns: assetsByAlias() and assetsByVersion().
@rap1ds rap1ds merged commit 2a1dfd1 into master May 9, 2023
1 check passed
@rap1ds rap1ds deleted the multi-asset-api branch May 9, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants