Set custom user agent for SDK #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In browser environment, the sdk user-agent string is appended to the browser's own UA string.
bladealslayer
force-pushed
the
sdk-custom-user-agent
branch
from
8de8408
to
d644111
Compare
walterrw
reviewed
Apr 14, 2023
| const isBrowser = typeof window !== 'undefined' && typeof window.document !== 'undefined'; | ||
| const navigatorUserAgent = typeof navigator !== 'undefined' ? navigator.userAgent : ''; | ||
| const nodeVersion = | ||
| typeof process !== 'undefined' && typeof process.versions !== 'undefined' |
There was a problem hiding this comment.
Couldn't this be checked as process && process.versions? Same above ..
There was a problem hiding this comment.
We use the more strict checks in a bunch of places, so I guess that's been preferred in the past.
walterrw
reviewed
Apr 14, 2023
| @@ -0,0 +1,3 @@ | |||
| // Update this when updating package.json | |||
| const sdkVersion = '1.17.0'; | |||
There was a problem hiding this comment.
It's not ideal to have to remember to update both versions. Is there any other way to get the version from a single place at runtime? Perhaps via the environment npm config values?
There was a problem hiding this comment.
Those don't work runtime, I think. Probably possible to wrap somehow in build script that generate a js file, though. I'll leave it for future improvement, since releases aren't super frequent and it's in the instructions anyway.
walterrw
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In browser environment, the sdk user-agent string is appended to the browser's own UA string.
Adapted from earlier implmenetation sharetribe/flex-integration-sdk-js#60