sharetribe-scripts v6.0 and GENERATE_SOURCEMAP=false

[anh-dinh-jh]

Describe the bug

On the new templates using sharetribe-scripts v6.0, set GENERATE_SOURCEMAP = false, got an error:

create-react-app config structure changed, please check webpack.config.js and update to use the changed config

To Reproduce Steps to reproduce the behavior:

1. Set GENERATE_SOURCEMAP = false
2. Run command yarn dev or yarn build
3. See error

Expected behavior

No errors

Reasons

sharetribe-scripts v6.0:

File: packages/react-scripts/config/sharetribeWebpackConfig.js

hasRules is false, which causes the configStructureKnown is false and then throws an error.

  const hasRules =
      config &&
      config.module &&
      config.module.rules &&
      config.module.rules.length === 2;
    
  ...

  const configStructureKnown = hasRules
        && hasOneOf
        && hasCssLoader
        && hasPlugins
        && hasOutput
        && hasOptimization;

  if (!configStructureKnown) {
    throw new Error(
      'create-react-app config structure changed, please check webpack.config.js and update to use the changed config'
    );
  }

Changes on FB react-scripts
PR: This
react-scripts PR: This

File: packages/react-scripts/config/webpack.config.js
Changes:

[
  // Handle node_modules packages that contain sourcemaps
  shouldUseSourceMap && {
    enforce: 'pre',
    exclude: /@babel(?:\/|\\{1,2})runtime/,
    test: /\.(js|mjs|jsx|ts|tsx|css)$/,
    loader: require.resolve('source-map-loader'),
  },
  ...
].filter(Boolean)

With this change: GENERATE_SOURCEMAP = false --> shouldUseSourceMap is false --> config.module.rules.length is 1 --> config.module.rules.length===2 is false --> configStructureKnown is false and then throws an error.

[Gnito]

@anh-dinh-jh thanks for reporting this. As mentioned in the other issue, we have had a vacation season, which caused some lag in responses on our part.

The configStructureKnown is now refactored to better work with environment variables (like GENERATE_SOURCEMAP) that affect the config structure.

The fix is not yet fully released, but here's a candidate:
sharetribe/create-react-app#25

[Gnito]

Now the sharetribe-scripts v6.0.1 is released and taken into use on the master branch of FTW-daily.

[Gnito]

A new release is made with the updated sharetribe-scripts.
I'm closing this issue.