Transaction process 1/4: Add new schema, save new data to new schema #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No it doesn't! But that's just the way Rails wants it to be. TransactionType contains the transaction_process_id foreign key. This is for the future, when we may want to change the process that is associated to the transaction type.
| class CreateTransactionProcesses < ActiveRecord::Migration | ||
| def change | ||
| create_table :transaction_processes do |t| | ||
| t.string :process, null: false |
There was a problem hiding this comment.
btw. what do you think, should this string be limited from default 255?
|
👍 |
|
|
||
| transaction_type = Object.const_get(type.to_s).create!(:type => type, :community_id => community.id) | ||
| transaction_type.create_transaction_process(process: opts[:process]) |
There was a problem hiding this comment.
It'd be better to use create_transaction_process! as it throws instead of returning false on invalid association object.
- Add community_id to TransactionProcess - Remove belongs_to and has_one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
belongs_tosince the foreign key is in the TransactionType model