Don't SQL join community_memberships if not needed #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting still tests to pass, but after that this can be reviewed. |
rap1ds
changed the title
rap1ds
force-pushed
the
remove-community-memberships-from-sql
branch
from
50d7c59
to
0973bbf
Compare
|
Tests are failing, needs more work. |
rap1ds
force-pushed
the
remove-community-memberships-from-sql
branch
from
0973bbf
to
ae630dd
Compare
|
Now tests are fixed. One test is still failing but that's random :( |
|
LGTM, didn't test so test thoroughly. |
rap1ds
force-pushed
the
remove-community-memberships-from-sql
branch
from
e2174c7
to
5d75d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.