Fix CLP top-bar assets not linked to asset_host when configured #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens, because we use ActionController::Metal and the setting of config.action_controller.asset_host doesn't take effect. Alternatively, we could load a bunch of extra modules and hooks, but it seems an overkill: include AbstractController::AssetPaths include ActionController::ParamsWrapper ActiveSupport.run_load_hooks(:action_controller, self)
| <%= stylesheet_link_tag 'app-bundle' %> | ||
| <%= javascript_include_tag 'vendor-bundle' %> | ||
| <%= javascript_include_tag 'app-bundle' %> | ||
| <% asset_host = local_assigns.key?(:asset_host) ? asset_host : nil %> |
There was a problem hiding this comment.
What happens if asset_host can not be found? Assets are served from rails?
There was a problem hiding this comment.
Yes, the link to the asset will be /assets/something, so served from the same domain as the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens, because we use
ActionController::Metaland thesetting of
config.action_controller.asset_hostdoesn't take effect.Alternatively, we could load a bunch of extra modules and hooks, but it
seems an overkill, because there are lots of hooked hooks, it seems: