Fix #2885 Landing page always shows sign up button for private marketplaces #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rap1ds
force-pushed
the
private-landing-page
branch
from
ebd75c2
to
ebe43b2
Compare
|
Uh, tests are failing. I'll fix them |
| def fetch_cached_content(community_id, version, digest) | ||
| Rails.cache.read("clp/#{community_id}/#{version}/#{digest}") | ||
| def fetch_cached_content(community_id, version, digest, cta) | ||
| Rails.cache.read("clp/#{community_id}/#{version}/#{digest}/#{cta}") |
There was a problem hiding this comment.
I'm not sure you need cta in the content cache keys. The content is different, so the digest will be different. As long as you have the meta based on the correct cta, it should be fine.
| end | ||
|
|
||
| def cache_content!(community_id, version, locale, content, cache_time) | ||
| def cache_content!(community_id, version, locale, content, cache_time, cta) |
| def write_cached_content!(community_id, version, content, digest, cache_time) | ||
| Rails.cache.write("clp/#{community_id}/#{version}/#{digest}", content, expires_in: cache_time) | ||
| def write_cached_content!(community_id, version, content, digest, cache_time, cta) | ||
| Rails.cache.write("clp/#{community_id}/#{version}/#{digest}/#{cta}", content, expires_in: cache_time) |
rap1ds
force-pushed
the
private-landing-page
branch
from
ebe43b2
to
a4eb266
Compare
| end | ||
|
|
||
| ## Internal, use cache_content! instead | ||
| def write_cached_content!(community_id, version, content, digest, cache_time) | ||
| Rails.cache.write("clp/#{community_id}/#{version}/#{digest}", content, expires_in: cache_time) | ||
| Rails.cache.write("clp/#{community_id}/#{version}/#{digest}/", content, expires_in: cache_time) |
rap1ds
force-pushed
the
private-landing-page
branch
from
a4eb266
to
b59789c
Compare
rap1ds
force-pushed
the
private-landing-page
branch
from
b59789c
to
8d48c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: See #2885 for detailed description about the issue
Solution:
cta(which can be eithersignuporsearch) for private marketplace.