custom landing page: include custom head scripts #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failures are unrelated to implementation |
sktoiva
suggested changes
Aug 18, 2017
| @@ -139,6 +140,13 @@ def index | |||
| # rubocop:enable AbcSize | |||
| # rubocop:enable MethodLength | |||
|
|
|||
| include ActionView::Helpers::JavaScriptHelper | |||
|
|
|||
| def custom_head_scripts | |||
There was a problem hiding this comment.
I guess these changes should be in landing_page_controller?
There was a problem hiding this comment.
@sktoiva @thomasmalbaux issues resolved
valdis
force-pushed
the
custom-scripts-for-landing-page
branch
from
9ba33f9
to
abfc100
Compare
valdis
force-pushed
the
custom-scripts-for-landing-page
branch
from
abfc100
to
696bc0f
Compare
…ts-for-landing-page' preload community for custom landing scripts See merge request !32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.