Add GitHub account SSH key checking #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/client/src/client/views.clj
Outdated
| @@ -24,7 +24,7 @@ | |||
| [:header#top | |||
| [:h1 [:a.home {:href "/"} "sharing.io"]] | |||
| [:nav | |||
| (when permitted-member | |||
| (when (and permitted-member (not (empty? (:ssh-keys user))))(not= (:ssh-keys user) nil) | |||
There was a problem hiding this comment.
In clojure, if you call empty? on a string, it will return true if string == "" or string == nil.
So this conditional could be simplified to:
(when (and permitted-member (not (empty? (:ssh-keys user)))))
However, there's an option to simplify it further using a clojure idiom. Instead o calling (not (empty? val)) you can just say (seq val), as it will return nil if the value is "" or nil, and nil is a falsy value for the purpose of this conditional statement.
In that case, the code could be reduced to:
(when (and permitted-member (seq (:ssh-keys user)))
...do-stuff)
There was a problem hiding this comment.
Oh! The (not= (:ssh-keys user) nil) might've been from when I was testing around things.
Testing it with (seq ...) works very well! Geez, that's so simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134