Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia syntax highlighting bug #1692

Closed
Moelf opened this issue Jun 17, 2021 · 4 comments
Closed

Julia syntax highlighting bug #1692

Moelf opened this issue Jun 17, 2021 · 4 comments
Labels
bug Something isn't working syntax-highlighting upstream-error A bug in an upstream component

Comments

@Moelf
Copy link

Moelf commented Jun 17, 2021

a = 64
b = Float64[]
c = Int[]

image

As you can see the 64 in Float64 is inappropriately highlighted as a number.
For comparison this is what the code looks like in neovim with JuliaVim:
image

IMO can we use more up-to-date "source" such as: highlightjs/highlight.js#2832 instead of the "sublime text" highlight?

@Moelf Moelf added the bug Something isn't working label Jun 17, 2021
@keith-hall
Copy link
Collaborator

IMO can we use more up-to-date "source" such as: highlightjs/highlight.js#2832 instead of the "sublime text" highlight?

The Julia sublime-syntax definition was last updated 23 days ago, seems quite recent to me. JuliaEditorSupport/Julia-sublime@48639e1
But no, bat relies on sublime-syntax files, there is no support for js highlighting libraries, nor are we likely to add any.

@Moelf
Copy link
Author

Moelf commented Jun 26, 2021

@keith-hall not their issue apparently

@keith-hall
Copy link
Collaborator

It's possible that we need to reference a newer Julia submodule version, but it may use more recent features which the syntax highlighting library we are using doesn't handle yet.

@sharkdp
Copy link
Owner

sharkdp commented Jul 13, 2021

Fixed in v0.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working syntax-highlighting upstream-error A bug in an upstream component
Projects
None yet
Development

No branches or pull requests

3 participants