Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new --style called default that is not necessarily same as full #2061

Closed
Enselic opened this issue Feb 5, 2022 · 1 comment · Fixed by #2119
Closed

Introduce new --style called default that is not necessarily same as full #2061

Enselic opened this issue Feb 5, 2022 · 1 comment · Fixed by #2119
Labels
feature-request New feature or request
Milestone

Comments

@Enselic
Copy link
Collaborator

Enselic commented Feb 5, 2022

There is a discussion in #1988 whether or not to include header-filesize in the default --style. The safest way forward is to be conservative and not include header-filesize by default. At least not yet. We can maybe make it default later.

To achieve that, we need a new style. I propose we simply call it default.

So we would have:

                     * default: enables recommended components (can change across versions) (default).\n  \
                     * full: enables all available components.\n  \
                     * auto: same as 'default', unless the output is piped.\n  \
                     * [... same as before ...]

Having (can change across versions) in the description is not very elegant. For now I just put it there for clarity. I think the implementation will be quite easy if we can agree on e.g. a name for the new style. We don't necessarily need to call it default.

It would be good to also take the opportunity to get rid of auto while we are at it. See #1743.

@sharkdp
Copy link
Owner

sharkdp commented Feb 5, 2022

Sounds good to me. I am in favor of introducing default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants