Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for serde-yaml 0.9 #2627

Closed
plugwash opened this issue Jul 22, 2023 · 4 comments · Fixed by #2690
Closed

Update for serde-yaml 0.9 #2627

plugwash opened this issue Jul 22, 2023 · 4 comments · Fixed by #2690
Assignees

Comments

@plugwash
Copy link

plugwash commented Jul 22, 2023

Hi.

In debian we are currently working on updating the serde-yaml crate, while we do have a mechanism for packaging multiple versions of a crate it is something we try to avoid where possible. So I have been testing reverse-dependencies of serde-yaml with the dependency bumped.

After bumping the dependency, bat itself built fine and it's tests passed. However one of the examples needed a small patch to avoid using a removed function.

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/3a24d2e9344d0a204bab9af9bc9cadfb375f81fc/src/bat/debian/patches/serde-yaml-0.9.diff

@sharkdp
Copy link
Owner

sharkdp commented Sep 1, 2023

master now uses serde 1.0, so I guess this can be closed.

@sharkdp sharkdp closed this as completed Sep 1, 2023
@plugwash
Copy link
Author

plugwash commented Sep 4, 2023

serde-yaml != serde, the latter has been at 1.x for ages, the former has still not reached 1.0

@plugwash
Copy link
Author

plugwash commented Sep 4, 2023

Sorry, I've realised I made a typo, it's serde_yaml not serde-yaml.

@sharkdp sharkdp reopened this Sep 4, 2023
@Raghav-Bell
Copy link
Contributor

Please assign this issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants