Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing with puffin! #35

Closed
wants to merge 1 commit into from
Closed

Conversation

siedentop
Copy link
Contributor

Amazing framework. Thanks a lot to the the puffin developers. Thanks to @emilk for helping out

How to use it is described in the Readme:

cargo run --example create_test_file
cargo run --features trace -- binocle_test_file

In another terminal run:

cargo install puffin_viewer
puffin_viewer --url 127.0.0.1:8585

Amazing framework. Thanks a lot!

How to use it is described in the Readme
@siedentop
Copy link
Contributor Author

FYI: @sharkdp

@siedentop
Copy link
Contributor Author

siedentop commented Nov 12, 2021

The build failure is persistent also on my forked repo: https://github.com/siedentop/binocle/runs/4194742703?check_suite_focus=true

Issue is on "windows-2019 (x86_64-pc-windows-gnu)", and zstd custom build command is failing.

I would like to just disable the tracing feature for this platform then.

Relevant links:

@sharkdp
Copy link
Owner

sharkdp commented Nov 14, 2021

Thank you for making me aware of this framework. This sounds really helpful. However, I'd rather not include tracing support by default here in this project - even if it's hidden behind a feature flag. I'd would try to avoid having to maintain this in the future. This PR/branch is still valuable for documentation purposes though!

Remark: if you want to make code like this optional, you can/should also make the necessary dependencies optional: https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies

@sharkdp sharkdp closed this Nov 14, 2021
@siedentop
Copy link
Contributor Author

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants