Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chapter #46

Merged
merged 3 commits into from
Mar 7, 2022
Merged

New chapter #46

merged 3 commits into from
Mar 7, 2022

Conversation

tomyuval
Copy link
Contributor

@tomyuval tomyuval commented Feb 2, 2022

No description provided.

- This function is a useful general utility
- This commit will facilitate its reuse in future chapters
@tomyuval
Copy link
Contributor Author

tomyuval commented Feb 2, 2022

Hey @sharkdp, I've added a new chapter (Chapter 4, keeping the previous Chapter 4 last, now as Chapter 5). Check it out!

Reservations:

  • I'm new to PureScript, so it's possible my code is not the most idiomatic.
  • I'm new to this repository, so it's possible some of my changes and/or additions are not perfectly in line with the existing style and/or intent.
  • I haven't invested too much time into it; while I think the new levels I've added are nice and my difficulty indications are roughly suitable, it's possible they could be made nicer and/or someone else will find them easier.

So I'm open to feedback, and otherwise feel free to merge the new levels in whole or in part, as is or with further changes.

@sharkdp
Copy link
Owner

sharkdp commented Feb 7, 2022

Thank you very much! I like it!

Is it possible to create harder levels with this idea? I basically solved all of the existing levels on first try (loved the idea of the last level, where partition* is not needed).

@tomyuval
Copy link
Contributor Author

Thanks for the feedback, @sharkdp!

(loved the idea of the last level, where partition* is not needed)

Yeah, I thought it would be a nice twist :)
But you don't mean the last level, but rather the third level (out of five), right? That's the one that does not make use of partition*, while the last one actually does.

Is it possible to create harder levels with this idea?

I thought the last level (the one which is really last) was a bit challenging – have you tried it and found it too easy?

In any case, it's certainly possible to make harder levels too! I pushed some ideas – all variations on the original last level – to https://github.com/tomyuval/cube-composer/tree/706cc9132397ecf835ff406f4bf3b8b4a4518213, check it out (all levels of Chapter 4 there – they replace the current levels; it's not meant to be merged as is, just to give us some ideas to play around with).

I might also try other levels based on slightly different themes with the same transformers.

@sharkdp
Copy link
Owner

sharkdp commented Feb 11, 2022

Oh, I think I only played the first three levels for some reason 😄. Will have another look when I find the time.

@tomyuval
Copy link
Contributor Author

Great, @sharkdp!

In the meantime I've added yet more potential levels at https://github.com/tomyuval/cube-composer/tree/6ef76cc20c7f5fa17cad4535cbe02f4666fadadf.

@sharkdp
Copy link
Owner

sharkdp commented Mar 6, 2022

I played the other levels now. I love it. Should I merge it in this state or do you want to experiment with other levels first?

@tomyuval
Copy link
Contributor Author

tomyuval commented Mar 7, 2022

Awesome, @sharkdp, happy to hear it!
I'm happy with merging the current PR as is; we (you, I, anyone else) can always suggest improvements at a later stage :)

@sharkdp sharkdp merged commit b144aff into sharkdp:master Mar 7, 2022
@tomyuval tomyuval deleted the new-chapter branch March 7, 2022 15:30
@sharkdp
Copy link
Owner

sharkdp commented Mar 7, 2022

Deployed :-)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants