Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for comma-separated arguments #8

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Support for comma-separated arguments #8

merged 1 commit into from
Jun 20, 2019

Conversation

hmenke
Copy link
Contributor

@hmenke hmenke commented Jun 20, 2019

Fixes #2.

@sharkdp
Copy link
Owner

sharkdp commented Jun 20, 2019

Fantastic, thank you very much!

@sharkdp sharkdp merged commit baf457f into sharkdp:master Jun 20, 2019
@sharkdp
Copy link
Owner

sharkdp commented Jun 20, 2019 •
edited

I actually just reverted the merge - I should have tested this first, sorry. Allowing for multiple arguments like I described in #2 is not compatible with using dbg(…) in expressions. I would really like to keep that functionality.

I should have thought about this before writing #2.

If we allow for dbg(x, y, …), we would have to make a rather arbitrary choice of just returning x.

@hmenke hmenke deleted the varargs branch June 21, 2019 23:31
@ShikChen ShikChen mentioned this pull request Jul 24, 2019
Closed
@sharkdp sharkdp mentioned this pull request Dec 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for multiple comma-separated arguments?
2 participants
@hmenke @sharkdp