Path should be escaped when running '-x cmd'

[sharkdp]

This seems like a bug to me

> touch 'file with spaces'

> fd -x 'ls "{}"'    # this is fine
file with spaces

> fd -x ls       
ls: cannot access 'file': No such file or directory
ls: cannot access 'with': No such file or directory
ls: cannot access 'spaces': No such file or directory

@mmstick - I'm mentioning you here just in case you are interested. I'm not trying to assign this to you.

[mmstick]

GNU Parallel also implements these flags for this use case -- quoting inputs. Not really a bug, but a convenience flag so you don't have to manually quote it yourself.

[mmstick]

The --quote flag, that is

[jakwings]

Why not quote it by default?

[mmstick]

@iology You can have an input that provides multiple arguments. In that case, you don't want quoting to happen.

[mmstick]

Although I guess when all of your inputs are files, it'd make sense to quote by default.

[sharkdp]

Although I guess when all of your inputs are files, it'd make sense to quote by default.

Yes, I also think so. The flag might be useful for parallel, but it shouldn't be needed here.

[mmstick]

I'll have this fixed soon. Am going to look for a way of possibly optimizing my solution though. Best way to do this isn't to quote, exactly, but to escape special characters.

[mmstick]

Am going to convert that paths module into an input module that uses a state machine to generate input strings, only allocating as needed. Will ensure that the programmer doesn't forget to escape the input before using it, preventing a possible logic error.