Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for clap 4.4.6 #1397

Closed
plugwash opened this issue Oct 17, 2023 · 1 comment
Closed

Support for clap 4.4.6 #1397

plugwash opened this issue Oct 17, 2023 · 1 comment

Comments

@plugwash
Copy link

plugwash commented Oct 17, 2023

Hi.

In debian, we recently upgraded clap to version 4.4.6, since this was not a semver bump we were not expecting any breakage. Unfortunately it turns out it broke fd.

There are (at least) two issues, the first is that the "unstable-grouped" feature was remved in clap 4.2.0 by the commit clap-rs/clap@d5089b2 "fix!: Remove stablized unstable-grouped feature". By removing the reference to the "unstable-grouped" feature I was able to successfully build fd and run it's tests against clap versions 4.2.0 through 4.2.4.

The second issue arises starting with clap version 4.2.5, a bunch of tests fail with errors like.

---- test_custom_ignore_files stdout ----
thread 'test_custom_ignore_files' panicked at '`fd --ignore-file custom.ignore foo` did not exit successfully.
stdout:
---
---
stderr:
---
thread 'main' panicked at 'Command fd: Argument group 'execs' conflicts with non-existent 'has_results' id', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/clap_builder-4.2.5/src/builder/debug_asserts.rs:317:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---', tests/testenv/mod.rs:238:13

I'm not sure what should be done about this second issue.

@plugwash plugwash changed the title Support for clap 4.4.5 Support for clap 4.4.6 Oct 17, 2023
@tmccombs
Copy link
Collaborator

I can look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants