Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin: offset should add to skip, not override it #119

Merged
merged 1 commit into from
Oct 31, 2020
Merged

bin: offset should add to skip, not override it #119

merged 1 commit into from
Oct 31, 2020

Conversation

tommilligan
Copy link
Contributor

Closes #115

This PR aligns the behaviour of hexyl with xxd, when the --skip and --display-offset flags are both set.

Currently, --display-offset overrides --skip . In xxd, the two values are added together to produce the first address value.

Comparison of current hexyl and xxd behaviour.

@tommilligan tommilligan mentioned this pull request Oct 30, 2020
Closed
@sharkdp sharkdp merged commit 524a6c6 into sharkdp:master Oct 31, 2020
@sharkdp
Copy link
Owner

sharkdp commented Oct 31, 2020

Thank you very much!

@ErichDonGubler ErichDonGubler mentioned this pull request Nov 16, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argument --display-offset overrides position in sidebar, not offsets it.
2 participants
@tommilligan @sharkdp