Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed null char to • #169

Closed
wants to merge 1 commit into from
Closed

Changed null char to • #169

wants to merge 1 commit into from

Conversation

LemonjamesD
Copy link

Kinda Resolves #166
This PR will changed the null char to • but it will not add the option to make it that or change it back to 0.

(For Hacktoberfest)

@sharkdp
Copy link
Owner

sharkdp commented Oct 3, 2022

We already use a similar (the same?) Unicode code point for AsciiOther (see a few lines below your change), so that's not the best solution here, IMO.

@LemonjamesD
Copy link
Author

I know that, could change it to . like other hex editors

@sharkdp
Copy link
Owner

sharkdp commented Nov 13, 2022 •
edited
Loading

If you look a few lines below your change, you could see that we already use • for AsciiOther. I looked around a bit and tried a few Unicode characters. So far, I like ⋄ best. It can be recognized as a 0 and it's not an ASCII character.

@sharkdp sharkdp mentioned this pull request Nov 13, 2022
Closed
@LemonjamesD
Copy link
Author

That would work, I'll see about changing it tonight if you're not gonna do it today

@sharkdp
Copy link
Owner

sharkdp commented Dec 5, 2022

Solved in 7d38f70

@sharkdp sharkdp closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to disable printing 0 bytes as ascii 0.
2 participants
@LemonjamesD @sharkdp