Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/dev/zero fix #204

Closed
wants to merge 0 commits into from
Closed

/dev/zero fix #204

wants to merge 0 commits into from

Conversation

sharifhsn
Copy link
Contributor

Fixes #200

@sharifhsn sharifhsn closed this Dec 10, 2023
@sharkdp
Copy link
Owner

sharkdp commented Dec 11, 2023

Was this closed intentionally?

@sharifhsn
Copy link
Contributor Author

No, I think when I rebased #194 it closed this PR. I would appreciate it if you could direct commit this change to master, as it's fairly trivial. Here's the commit: sharifhsn@c189d60

@sharkdp
Copy link
Owner

sharkdp commented Dec 11, 2023

The change is trivial, but I wonder if there are any performance implications of flushing?

@sharkdp
Copy link
Owner

sharkdp commented Dec 11, 2023 •
edited
Loading

There is... unfortunately. 35% slower:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hexyl /dev/zero hangs
2 participants
@sharifhsn @sharkdp