Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup command which is executed at the end of each benchmark #129

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

colinwahl
Copy link

Fixes #91.

I am still a beginner at Rust, so I'm very open to feedback. Thanks!

@sharkdp
Copy link
Owner

sharkdp commented Jan 9, 2019

Thank you very much for your contribution!

I will do a full review soon, but what I've seen so far looks great. I think we should work a little bit on the --help text to clearly explain what the difference from --prepare is. The prepare-command will be executed before each benchmarking run (several times for every benchmarked command) while the cleanup command will only be called once after a set of benchmark runs (once for every benchmarked command).

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. The rest of the changes looks great!

.takes_value(true)
.value_name("CMD")
.help(
"Execute CMD after each benchmark run. This is useful for \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated previously, we should clarify the help text here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it needs some clarification, how does this sound?

"Execute CMD after the benchmarking runs for each individual command to be benchmarked. This is useful if the commands to be benchmarked produce artifacts that need to be cleaned up."

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I have updated the code.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants