Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some lints #194

Merged
merged 13 commits into from
Jul 17, 2019
Merged

Fix some lints #194

merged 13 commits into from
Jul 17, 2019

Commits on Jul 17, 2019

  1. Return value directly

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    fa77bed View commit details
    Browse the repository at this point in the history

  2. Avoid closure

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    46ed4ba View commit details
    Browse the repository at this point in the history

  3. Factor common operations into closure

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    bb759b4 View commit details
    Browse the repository at this point in the history

  4. Avoid redundant field names

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    d76ef8d View commit details
    Browse the repository at this point in the history

  5. Avoid redundant return

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    807e443 View commit details
    Browse the repository at this point in the history

  6. Avoid long literal without separator

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    c10e885 View commit details
    Browse the repository at this point in the history

  7. Avoid redundant explicit borrow

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    e912018 View commit details
    Browse the repository at this point in the history

  8. Use f64::from instead of as f64

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    b4e2275 View commit details
    Browse the repository at this point in the history

  9. Avoid redundant ref

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    842a498 View commit details
    Browse the repository at this point in the history

  10. Use slices instead of borrowed vectors

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    b01fc99 View commit details
    Browse the repository at this point in the history

  11. Use slices instead of borrowed string

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    b0345ba View commit details
    Browse the repository at this point in the history

  12. Pass Copyable enums by value

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    8bdf36e View commit details
    Browse the repository at this point in the history

  13. Use byte literal instead of as u8

    philipp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    a188610 View commit details
    Browse the repository at this point in the history