New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple --prepare support #218
Add multiple --prepare support #218
Conversation
Signed-off-by: Saurav Sharma <appdroiddeveloper@gmail.com>
Thank you for your contribution.
I would solve both problems by issuing an error message if |
Signed-off-by: Saurav Sharma <appdroiddeveloper@gmail.com>
@sharkdp How would you like to raise error currently I am directly raising error by calling error function which is simple. And any suggestion over error message which was raised I think this is not best error message for this error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. I added some comments.
Signed-off-by: Saurav Sharma <appdroiddeveloper@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
Add support for multiple --prepare option. Corresponding --prepare option will be used for command for benchmarking according to position. If --prepare option is less than benchmark command then all other remaining benchmark command will use last prepare option ( This logic may not be best logic to implement out). If prepare option is more than command for benchmarking then extra --prepare option will not be used
Part of #216