Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse --shell option as shell command #436

Merged
merged 3 commits into from
Oct 17, 2021
Merged

Parse --shell option as shell command #436

merged 3 commits into from
Oct 17, 2021

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Oct 4, 2021

Fixes #410.

I did small sanity check for both normal case and error case:

スクリーンショット 2021-10-04 22 51 49

@rhysd rhysd mentioned this pull request Oct 4, 2021
Closed
@rhysd
Copy link
Contributor Author

rhysd commented Oct 4, 2021

I fixed all reported clippy warnings as well.

@sharkdp sharkdp merged commit f2bfedd into sharkdp:master Oct 17, 2021
@sharkdp
Copy link
Owner

sharkdp commented Oct 17, 2021

Thank you very much - very clean implementation!

@rhysd
Copy link
Contributor Author

rhysd commented Oct 17, 2021

@sharkdp Thank you for the review and merge. I apologize for the conflicts among PRs.

@sharkdp sharkdp mentioned this pull request Oct 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--shell 'busybox sh', 'zsh --emulate posix', 'bash --posix'
2 participants
@rhysd @sharkdp