Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Winget Releaser workflow #622

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Add Winget Releaser workflow #622

merged 2 commits into from
Mar 15, 2023

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Mar 7, 2023

This action automatically generates manifests for Winget Community Repository (microsoft/winget-pkgs) and submits them.

Before merging this:

  1. Add a classic PAT with public_repo scope as a repository secret named WINGET_TOKEN.

example

  1. Fork https://github.com/microsoft/winget-pkgs under @sharkdp. The action will use that fork for making a branch and creating a PR with the upstream winget-pkgs repository on every release.
  2. Install Pull on the winget-pkgs fork to ensure that it is constantly updated.

You can test out the action inputs in this playground.

If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been created with WinGet Releaser).

@sitiom sitiom changed the title Add GitHub actions to Dependabot Add Winget Releaser workflow Mar 7, 2023
@sharkdp
Copy link
Owner

sharkdp commented Mar 12, 2023

Thank you. I would first like to understand if it's really necessary that I personally maintain this (I'd rather not, if possible). Couldn't that GA action run on a fork (of hyperfine, not winget - kept up to date by the pull action mentioned above) created by someone else?

@sitiom
Copy link
Contributor Author

sitiom commented Mar 13, 2023

I would first like to understand if it's really necessary that I personally maintain this

If you want the Winget package to be updated, that is. There isn't any built-in automation to Winget, unlike Scoop.

Couldn't that GA action run on a fork (of hyperfine, not winget - kept up to date by the pull action mentioned above)

That's not how it works. The action submits a PR to https://github.com/microsoft/winget-pkgs via your winget-pkgs fork.

@sharkdp sharkdp merged commit 92b9b3d into sharkdp:master Mar 15, 2023
@sitiom sitiom deleted the winget-releaser branch March 15, 2023 09:16
@sitiom
Copy link
Contributor Author

sitiom commented Mar 15, 2023

@sharkdp Failed. The binaries weren't available in the releases: https://github.com/sharkdp/hyperfine/actions/runs/4424630811. Rerun the workflow again once you have added them.

@sharkdp
Copy link
Owner

sharkdp commented Mar 15, 2023

Well, the binaries are added by another GA pipeline. Maybe that pipeline can "wait" for the other one somehow? Or be delayed?

@sitiom
Copy link
Contributor Author

sitiom commented Mar 15, 2023

I think I should've workflow should've been added inside https://github.com/sharkdp/hyperfine/blob/master/.github/workflows/CICD.yml instead.

@sharkdp
Copy link
Owner

sharkdp commented Mar 15, 2023

It failed again

@sitiom
Copy link
Contributor Author

sitiom commented Mar 15, 2023

image

It seems like you didn't add the WINGET_TOKEN secret in this repo.

@sitiom
Copy link
Contributor Author

sitiom commented Mar 15, 2023

I have manually created a PR of the new version for now: microsoft/winget-pkgs#99531

@sharkdp
Copy link
Owner

sharkdp commented Mar 15, 2023

It seems like you didn't add the WINGET_TOKEN secret in this repo.

Oh, I missed that part in step 2. For future PRs, I would suggest to split that into two steps. Fixed now.

@sitiom
Copy link
Contributor Author

sitiom commented Mar 16, 2023

Oh, I missed that part in step 2

It's actually step 1 😅

  1. Add a classic PAT with public_repo scope as a repository secret named WINGET_TOKEN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinGet-based installation
2 participants