Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history file location #188

Closed
bAndie91 opened this issue Jan 11, 2019 · 1 comment
Closed

history file location #188

bAndie91 opened this issue Jan 11, 2019 · 1 comment
Labels
cli easy

Comments

@bAndie91
Copy link
Contributor

hi, could you please consider moving history file from under XDG config into XDG data (~/.local/share) directory. history files are usually there as i observed. thanks. nice tool.
@sharkdp
Copy link
Owner

sharkdp commented Jan 13, 2019

Sounds reasonable. We would probably have to change this line:

insect/index.js

Line 57 in 0663801

path: path.join(xdgBasedir.config, "insect-history"),

bAndie91 pushed a commit to bAndie91/insect that referenced this issue Jan 14, 2019
save history in XGD data dir instead of config
0432b79 
addressing sharkdp#188
@bAndie91 bAndie91 mentioned this issue Jan 14, 2019
Merged
sharkdp pushed a commit that referenced this issue Jan 14, 2019
@sharkdp
save history in XGD data dir instead of config
e666461 
addressing #188
@sharkdp sharkdp closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bAndie91 @sharkdp