Clear URL when clearing terminal

[n4bb12]

Follow-up of #169

[n4bb12]

The terminal also gets cleared when hitting Ctrl + L. https://terminal.jcubic.pl/api_reference.php#shortcuts

If I can find out how to catch that, then I'll add that, too.

[n4bb12]

See docs at https://terminal.jcubic.pl/api_reference.php#terminal_keymap

[n4bb12]

@sharkdp The issue with removing the leading / is that it breaks clear. The URL can only be cleared by replacing the history state with /. But that triggers the error here #171.

The problem does not occur if you serve the folder with an actual web server instead of just opening the file.

I think you need to decide here if a working clear is more important, or being able to open the web page without a web server.

[sharkdp]

Oops. I was too quick with merging, sorry 😄

I think you need to decide here if a working clear is more important, or being able to open the web page without a web server.

If there is no way to extract the base url (/ or ../index.html), I think I would choose the latter option (be able to just open the index.html in a browser).

[n4bb12]

Since you're already using npm, I'd suggest to add https://www.npmjs.com/package/live-server to the project. Devs can run npm start and get a working server without the need to install anything on top. As a nice bonus you also get automatic refresh when editing the html.

[n4bb12]

I tested a few things and this worked for me, too:

// This resets the URL when opening the app as a file
history.replaceState(null, null, "index.html")

We can distinguish a local file from a web server by checking

location.href

If you want to go with that instead

[sharkdp]

I think we could store location.href once in the beginning:

var origin = location.href;

and then simply revert to that when clear is called. What do you think?

[n4bb12]

Yea that.

You can't directly revert to it since the history API only accepts relative paths, but it does contain the necessary info to make it work.

Want a PR? 😄

[sharkdp]

Hm, it seems to be okay if the base URL is still the same. But that might be just Chrome.

[n4bb12]

You are right. What it actually doesn't accept is a URL with a different domain.