Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Spago dependencies and purs output in CI #373

Merged
merged 1 commit into from Apr 12, 2023

Conversation

triallax
Copy link
Collaborator

Fixes #342.

@sharkdp
Copy link
Owner

sharkdp commented Apr 2, 2023

Thank you for looking into this. I am usually very careful with caching in CI. If we absolutely must bring down CI times, that's certainly a good idea. But I have seen too many hard-to-debug errors that appeared because cache-invalidation didn't work for some reason (see your example with compiler versions, for example).

@triallax
Copy link
Collaborator Author

triallax commented Apr 2, 2023

That is a valid concern. Just to be clear, the compiler versions thing I mentioned was just a thing to investigate before implementing this; I do not know of any cases where it was an actual issue. Anyway, I think this comment and this one show that this should be safe. Additionally, resetting the cache or disabling this is trivial should it ever prove to be an issue.

@sharkdp
Copy link
Owner

sharkdp commented Apr 12, 2023

Additionally, resetting the cache or disabling this is trivial should it ever prove to be an issue.

That's the thing. Sometimes it's hard to know (or remember) that CI problems could be related to caching.

But I'm okay with giving this a try. Thank you!

@sharkdp sharkdp merged commit 0153e5a into sharkdp:master Apr 12, 2023
1 check passed
@triallax triallax deleted the cache-spago-stuff-in-ci branch April 12, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache dependencies (and compiler output too?) in GitHub workflows
2 participants