Move from test-unit to spec #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triallax
force-pushed
the
move-to-purescript-spec
branch
from
95e8aa1
to
9dcb53a
Compare
triallax
commented
May 28, 2023
triallax
force-pushed
the
move-to-purescript-spec
branch
from
9dcb53a
to
f8b59e6
Compare
The migration is rather straightforward, but it brings a HUGE decrease in the time required to run tests as determined by `hyperfine --warmup 2 'npm test'`. Before: Benchmark 1: npm test Time (mean ± σ): 71.245 s ± 0.619 s [User: 75.323 s, System: 0.868 s] Range (min … max): 70.245 s … 72.363 s 10 runs After: Benchmark 1: npm test Time (mean ± σ): 18.666 s ± 0.256 s [User: 22.082 s, System: 0.671 s] Range (min … max): 18.327 s … 19.048 s 10 runs
triallax
force-pushed
the
move-to-purescript-spec
branch
from
f8b59e6
to
8b6e0de
Compare
|
This is awesome, thank you very much |
|
@sharkdp you're welcome. I'm trying to merge "uncontroversial" PRs on my own initiative instead of waiting for your review. I hope that's fine with you? |
|
Yes, that is completely fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration is rather straightforward, but it brings a HUGE decrease in the time required to run tests as determined by
hyperfine --warmup 2 'npm test'. Before:After:
I'm also considering moving to assert instead, but it's much lower-level than the other two, so I'm not too sure about that. It could be worth a try though.