Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to terminal CLI #392

Merged
merged 1 commit into from Jul 22, 2023
Merged

Various improvements to terminal CLI #392

merged 1 commit into from Jul 22, 2023

Conversation

triallax
Copy link
Collaborator

@triallax triallax commented Jul 7, 2023 •
edited

  • Allow passing expression as multiple arguments
    This allows e.g. insect 1 + 1, whereas previously this would've caused an error.
  • Use insectrc in non-interactive mode too.
    Fixes Use insectrc in non-interactive operation #377.
  • Add alternative location for insectrc ($XDG_CONFIG_HOME/insect/ insectrc).
    Fixes Change .insectrc location #307.
  • Exit with non-zero exit code if evaluating argument fails.

@triallax triallax changed the title Allow passing expression as multiple arguments to Insect Various improvements to terminal CLI Jul 7, 2023
@triallax triallax added the cli label Jul 7, 2023
triallax
triallax commented Jul 7, 2023
View reviewed changes
index.dev.js Show resolved Hide resolved
triallax
triallax commented Jul 7, 2023
View reviewed changes
index.dev.js Show resolved Hide resolved
triallax
triallax commented Jul 7, 2023
View reviewed changes
index.dev.js Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Jul 12, 2023
View reviewed changes
index.dev.js Outdated Show resolved Hide resolved
sharkdp
sharkdp requested changes Jul 12, 2023
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a few minor comments

@triallax
Various improvements to terminal CLI
ebff878 
- Allow passing expression as multiple arguments
  This allows e.g. `insect 1 + 1`, whereas previously this would've
  caused an error.
- Use insectrc in non-interactive mode too.
  Fixes sharkdp#377.
- Add alternative location for insectrc ($XDG_CONFIG_HOME/insect/insectrc).
  Fixes sharkdp#307.
- Exit with non-zero exit code if evaluating argument fails.
@triallax triallax merged commit ffdf77d into sharkdp:master Jul 22, 2023
1 check passed
@triallax triallax deleted the allow-multiple-args branch July 22, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use insectrc in non-interactive operation Change .insectrc location
2 participants
@triallax @sharkdp